Avoid unneeded work for storage removal in non-opt builds in CopyProp and GVN

[ohadravid]

Fix performance regression introduced in #142531 (rust-timer comment) by only allocating local sets for the storage accounting when tcx.sess.emit_lifetime_markers().

r? saethlin

[rustbot]

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

[ohadravid]

Before, Replacer used unified to check which locals require storage removal - so this is fine
https://github.com/rust-lang/rust/pull/142531/changes#diff-0004c9822ecc282c9d6f6bcec22d1b50d49c6165e8093c1dbd2607086278dc19L96

View changes since the review

[Kobzol]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 48af6e0 (48af6e0fab57d8f8b2679fe3401c5b490589dad7, parent: b2f1ccf524a3a4cf9c34545167cc23b659cf1cbd)

[rust-timer]

Finished benchmarking commit (48af6e0): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 4.2%, secondary -1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.2%	[3.0%, 5.4%]	2
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.2%	[-4.2%, -4.2%]	1
All ❌✅ (primary)	4.2%	[3.0%, 5.4%]	2

Cycles

Results (primary 2.6%, secondary 6.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.6%	[2.6%, 2.6%]	1
Regressions ❌ (secondary)	6.2%	[3.8%, 8.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.6%	[2.6%, 2.6%]	1

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 492.524s -> 492.577s (0.01%)
Artifact size: 394.41 MiB -> 394.45 MiB (0.01%)