cmse: test returning MaybeUninit<T>#155522
Open
folkertdev wants to merge 2 commits intorust-lang:mainfrom
Open
cmse: test returning MaybeUninit<T>#155522folkertdev wants to merge 2 commits intorust-lang:mainfrom
MaybeUninit<T>#155522folkertdev wants to merge 2 commits intorust-lang:mainfrom
Conversation
The `MaybeUninit` type is `repr(transparent)`, so returning a `MaybeUninit<u64>` should work. The same is not true when using C or rust union types.
Collaborator
|
This PR modifies cc @jieyouxu |
MaybeUninit<T>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tracking issue: #81391
tracking issue: #75835
Some tests from #147697 that already work and are useful. Extracting them shrinks that (currently blocked) PR.
The code in
tests/ui/cmse-nonsecure/cmse-nonsecure-call/return-via-stack.rschecks thatMaybeUninit<T>is considered abi-compatible withT. The code intests/ui/cmse-nonsecure/cmse-nonsecure-entry/params-via-stack.rsreally only tests that no errors/warnings are emitted.r? davidtwco