Replace printables table with unicode_data.rs tables#155527
Open
Jules-Bertholet wants to merge 1 commit intorust-lang:mainfrom
Open
Replace printables table with unicode_data.rs tables#155527Jules-Bertholet wants to merge 1 commit intorust-lang:mainfrom
unicode_data.rs tables#155527Jules-Bertholet wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
If you want to modify |
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Jules-Bertholet
force-pushed
the
riir-printable
branch
from
c2aeaba to
fd13759
Compare
This comment has been minimized.
This comment has been minimized.
This gets rid of the `printable.py` script, ensuring that `unicode-table-generator` handles all our Unicode data table generation needs. There are also some drive-by documentation improvements in `library/core/char/methods.rs`. There is one change in behavior: we now consider all characters with the `Default_Ignorable_Code_Point` property to be unprintable. These characters can be hidden/invisible otherwise. I've elected to give each Unicode property its own table, instead of merging them all into one. This is slightly less efficient in terms of space, but should allow us to expose these tables in the future with public methods on `char`.
Jules-Bertholet
force-pushed
the
riir-printable
branch
from
fd13759 to
ab09b17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gets rid of the
printable.pyscript, ensuring thatunicode-table-generatorhandles all our Unicode data table generation needs.There are also some drive-by documentation improvements in
library/core/char/methods.rs.There is one change in behavior: we now consider all characters with the
Default_Ignorable_Code_Pointproperty to be unprintable. These characters can be hidden/invisible otherwise.I've chosen to give each Unicode property its own table, instead of merging them all into one. This is slightly less efficient in terms of space, but should allow us to expose these tables in the future with public methods on
char.@rustbot label A-Unicode