compiletest: Report filtered and --skip-ed tests in metrics #155555
Open
jyn514 wants to merge 2 commits intorust-lang:mainfrom
Open
compiletest: Report filtered and --skip-ed tests in metrics #155555jyn514 wants to merge 2 commits intorust-lang:mainfrom
jyn514 wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in src/tools/compiletest cc @jieyouxu |
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
2235bed to
c4f30fb
Compare
This comment has been minimized.
This comment has been minimized.
c4f30fb to
a04daaf
Compare
This comment has been minimized.
This comment has been minimized.
This allows testing metrics.
a04daaf to
b35ca65
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ferrocene depends on these metrics for our certification. For various reasons our CI invokes bootstrap with
--skipflags, so we want to report ignored tests even if they're ignored manually with--skip.To make sure this doesn't regress, add an integration test suite for compiletest itself. This can't fit into the existing
compiletest-self-testsuite because it's testing the interface between bootstrap and compiletest, not just whether the tests pass or fail. Hopefully this will come in handy for more things in the future.Changes in this PR:
build_helper. DeriveDebugon all its types.FilteredOutmetric kind. Handle it appropriately (by not doing anything) in progress reporting, but save it to the metrics.json file.