Adds a couple UI tests for polonius#155600
Open
CrooseGit wants to merge 2 commits intorust-lang:mainfrom
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
CrooseGit
force-pushed
the
dev/reucru01/adds-polonius-ui-tests
branch
from
228e455 to
8e25d0e
Compare
This comment has been minimized.
This comment has been minimized.
Fails on NLL, passes on polonius alpha & legacy.
CrooseGit
force-pushed
the
dev/reucru01/adds-polonius-ui-tests
branch
from
8e25d0e to
134aa1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went through all the open issues labeled
fixed-by-poloniusand from that created two UI tests based on issues that seemed a little novel.One for #92038 and another for #70044.
Both tests fail under NLL but pass with polonius (legacy and alpha).