Rewrite use-statement-duplicate-check-7663 test#155612
Open
qaijuang wants to merge 2 commits intorust-lang:mainfrom
Open
Rewrite use-statement-duplicate-check-7663 test#155612qaijuang wants to merge 2 commits intorust-lang:mainfrom
qaijuang wants to merge 2 commits intorust-lang:mainfrom
Conversation
8b2867f to
f5af5d9
Compare
f5af5d9 to
3443c7d
Compare
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
18b5006 to
9ea8064
Compare
Member
|
Hi, thanks for you contribution! Before proceeding with the review, could you briefly describe any use of LLMs for creation of this PR? Thanks! |
Author
|
Yes, for aid with PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #140780.
This supersedes the abandoned earlier attempt in #141060, which targeted an older test layout.
The existing
use-statement-duplicate-check-7663test had drifted away from the behavior from #7663 and no longer exercised duplicate import handling at all.This rewrites the test as a revision-based UI test that covers the three relevant cases:
Verification
./x test tests/ui/modules --test-args use-statement-duplicate-check-7663