Rollup of 10 pull requests by JonathanBrouwer · Pull Request #155655 · rust-lang/rust

JonathanBrouwer · 2026-04-22T17:18:34Z

Successful merges:

Add on_unmatch_args #154794 (Add on_unmatch_args)
Document precision considerations of Duration-float methods #155133 (Document precision considerations of Duration-float methods)
Remove nodes_in_current_session field and related assertions #154283 (Remove nodes_in_current_session field and related assertions)
rustdoc: fix a few spots where emit isn't respected #155374 (rustdoc: fix a few spots where emit isn't respected)
Immediately feed visibility on DefId creation #155587 (Immediately feed visibility on DefId creation)
c-variadic: va_arg fixes #155622 (c-variadic: va_arg fixes )
rustc_public: Add constness & asyncness in FnDef #155629 (rustc_public: Add constness & asyncness in FnDef)
Some metadata cleanups #155632 (Some metadata cleanups)
BinOpAssign always returns unit #155639 (BinOpAssign always returns unit)
rustc-dev-guide subtree update #155647 (rustc-dev-guide subtree update)

Fix link to hir::Crate in lowering.md

A `Duration` is essentially a 94-bit value (64-bit sec and ~30-bit ns), so there's some inherent loss when converting to floating-point for `mul_f64` and `div_f64`. We could go to greater lengths to compute these with more accuracy, like rust-lang#150933 or rust-lang#154107, but it's not clear that it's worth the effort. The least we can do is document that some rounding is to be expected, which this commit does with simple examples that only multiply or divide by `1.0`. This also changes the `f32` methods to just forward to `f64`, so we keep more of that duration precision, as the range is otherwise much more limited there.

The edition parameter was removed

…otif-grp-links Fix GPU target notification group links

…bors-squash Document quoting for `@bors squash msg=`

This updates the rust-version file to 14196db.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@14196db Filtered ref: rust-lang/rustc-dev-guide@9def1ed Upstream diff: rust-lang/rust@30d0309...14196db This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

@reddevilmidzy

This should be clear with less words r? @reddevilmidzy

…pang-patch-1 show instead of explain

This updates the rust-version file to 17584a1.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@17584a1 Filtered ref: rust-lang/rustc-dev-guide@ec71ad7 Upstream diff: rust-lang/rust@14196db...17584a1 This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

Update neovim instructions for neovim 0.11+

Update link for Rust reference documentation

`~const` was replaced with `[const]`, making uses of the former confusing

effects.md: update const trait syntax

- Only latest nightly crates' docs are published - How to get an old nightly docs

JonathanBrouwer · 2026-04-22T17:18:43Z

@bors r+ rollup=never p=5

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,x86_64-gnu-aux,x86_64-gnu-llvm-21-3,x86_64-msvc-1,aarch64-apple,x86_64-mingw-1,i686-msvc-2

rust-bors · 2026-04-22T17:18:46Z

📌 Commit e94e3cc has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 10 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-2

rust-bors · 2026-04-22T20:42:24Z

☀️ Try build successful (CI)
Build commit: 4718a18 (4718a18a0473fa7eb765319d7f4ccf71713df98b, parent: cf1817bc6ecd2d14ca492247c804bad31948dd56)

rust-bors · 2026-04-22T22:27:45Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 3h 11m 4s
Pushing 913e4be to main...

github-actions · 2026-04-22T22:30:37Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f676c20 (parent) -> 913e4be (this PR)

Test differences

Show 98 test diffs

Stage 1

[ui] tests/ui-fulldeps/rustc_public/check_fn_attrs.rs: [missing] -> ignore (ignored when the bootstrapping stage is stage1) (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/error_is_shown_in_downstream_crates.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/message_and_label.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/notes_on_extra_args.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/on_unmatch_args.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/other_match_macro_error.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_invalid_formats.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_invalid_meta_item_syntax.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_missing_options.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_non_macro.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_unknown_options.rs: [missing] -> pass (J0)
[ui] tests/ui/feature-gates/feature-gate-diagnostic-on-unmatch-args.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/diagnostic_namespace/on_unmatch_args/error_is_shown_in_downstream_crates.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/message_and_label.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/notes_on_extra_args.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/on_unmatch_args.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/other_match_macro_error.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_invalid_formats.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_invalid_meta_item_syntax.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_missing_options.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_non_macro.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unmatch_args/report_warning_on_unknown_options.rs: [missing] -> pass (J1)
[ui] tests/ui/feature-gates/feature-gate-diagnostic-on-unmatch-args.rs: [missing] -> pass (J1)
[ui] tests/ui-fulldeps/rustc_public/check_fn_attrs.rs: [missing] -> pass (J2)

Additionally, 74 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 913e4bea83424658d76712fee9c52452a3a9ef0e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

armhf-gnu: 1h 6m -> 1h 33m (+39.9%)
dist-ohos-x86_64: 1h 3m -> 1h 26m (+37.7%)
arm-android: 1h 38m -> 2h 10m (+32.5%)
test-various: 1h 29m -> 1h 57m (+31.5%)
i686-msvc-2: 1h 45m -> 2h 17m (+30.4%)
optional-x86_64-gnu-parallel-frontend: 2h 12m -> 2h 42m (+22.6%)
pr-check-1: 28m 7s -> 33m 41s (+19.8%)
aarch64-gnu-llvm-21-2: 46m 11s -> 54m 21s (+17.7%)
x86_64-gnu-stable: 2h 17m -> 1h 53m (-17.6%)
i686-gnu-2: 1h 31m -> 1h 46m (+16.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-22T22:30:47Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#154283	Remove `nodes_in_current_session` field and related asserti…	`1a7e42e3924e104b4b8c4948c81147a4eeefde44` (link)
#154794	Add on_unmatch_args	`74815d2faf46e5dd4bfa2bc04e6326e7a6917e30` (link)
#155133	Document precision considerations of `Duration`-float metho…	`512f95fe5b1062377cd0e81dbfebec6ae654bf12` (link)
#155374	rustdoc: fix a few spots where emit isn't respected	`f1357f9082056c071472a66a7526135343a81b77` (link)
#155587	Immediately feed visibility on DefId creation	`5c3400bba480d63cc0ef9d3a3b812e266621f530` (link)
#155622	c-variadic: `va_arg` fixes	`b2a0befdde4eb26d24abb27973b8b68e6f5bf180` (link)
#155629	rustc_public: Add `constness` & `asyncness` in `FnDef`	`fb56f44e432f109c588792e698177a38b097aa24` (link)
#155632	Some metadata cleanups	`a3a436fe000e80b05584b1b6bc7dc84f5ac703c2` (link)
#155639	BinOpAssign always returns unit	`21e307d191c5c62966a5077657eb736a59cf63a4` (link)
#155647	rustc-dev-guide subtree update	`708860003da0292744f29f69fd0fdce564cd977f` (link)

previous master: f676c20edd

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-04-22T23:08:41Z

Finished benchmarking commit (913e4be): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	2
Improvements ✅ (primary)	-0.8%	[-3.7%, -0.2%]	110
Improvements ✅ (secondary)	-1.2%	[-5.5%, -0.0%]	83
All ❌✅ (primary)	-0.8%	[-3.7%, -0.2%]	110

Max RSS (memory usage)

Results (primary -6.2%, secondary -5.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.6%	[1.7%, 7.9%]	5
Improvements ✅ (primary)	-6.2%	[-11.3%, -1.5%]	158
Improvements ✅ (secondary)	-6.4%	[-20.0%, -1.2%]	60
All ❌✅ (primary)	-6.2%	[-11.3%, -1.5%]	158

Cycles

Results (primary -4.8%, secondary -6.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.2%	[2.1%, 4.2%]	6
Improvements ✅ (primary)	-4.8%	[-13.6%, -1.5%]	77
Improvements ✅ (secondary)	-7.2%	[-21.9%, -1.9%]	53
All ❌✅ (primary)	-4.8%	[-13.6%, -1.5%]	77

Binary size

Results (secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	1
All ❌✅ (primary)	-	-	0

Bootstrap: 492.288s -> 492.161s (-0.03%)
Artifact size: 394.44 MiB -> 394.33 MiB (-0.03%)

nnethercote · 2026-04-22T23:22:47Z

@rust-timer build 1a7e42e

rust-timer · 2026-04-22T23:22:50Z

Missing artifact for sha 1a7e42e3924e104b4b8c4948c81147a4eeefde44 (https://ci-artifacts.rust-lang.org/rustc-builds/1a7e42e3924e104b4b8c4948c81147a4eeefde44/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz); not built yet, try again later.

nnethercote · 2026-04-23T01:10:03Z

#154283 is amost certainly the cause of the big perf improvements. Unfortunately they are artificial: rustc-perf enables -Zincremental-verify-ich and that PR almost entirely affects the extra operations done when that flag is enabled.

Kobzol · 2026-04-23T05:57:53Z

@rust-timer build 1a7e42e

rust-timer · 2026-04-23T05:57:57Z

Failed to enqueue some commit SHAs. Maybe they were already benchmarked?

lqd · 2026-04-23T07:31:47Z

Maybe they were already benchmarked?

#154283 (comment)

erfanio and others added 30 commits April 1, 2026 08:38

Update neovim instructions for neovim 0.11+

6f81506

Fix GPU target notification group links

69345f6

Address code review comments

314c14a

Use skip_comments to strip comments

0026340

Use double quotes consistently

d477368

Merge rust-analyzer settings instead of overwriting

8d96fa0

Fix link to hir::Crate in lowering.md

2455931

Merge pull request rust-lang/rustc-dev-guide#2829 from reddevilmidzy/hir

dbe3144

Fix link to hir::Crate in lowering.md

implementing-new-features.md: update parameters to declare_features!

d72b0e7

The edition parameter was removed

Merge pull request rust-lang/rustc-dev-guide#2821 from apiraino/fix-n…

d928b2b

…otif-grp-links Fix GPU target notification group links

Document quoting for @bors squash msg=

269feca

Merge pull request rust-lang/rustc-dev-guide#2831 from reddevilmidzy/…

5273a4c

…bors-squash Document quoting for `@bors squash msg=`

Prepare for merging from rust-lang/rust

9ddab4d

This updates the rust-version file to 14196db.

Merge pull request rust-lang#2832 from rust-lang/rustc-pull

d7b595c

Rustc pull update

show instead of explain

c315ef2

This should be clear with less words r? @reddevilmidzy

Merge pull request rust-lang/rustc-dev-guide#2833 from rust-lang/tshe…

c092fa7

…pang-patch-1 show instead of explain

Prepare for merging from rust-lang/rust

2a152e1

This updates the rust-version file to 17584a1.

Merge pull request rust-lang#2834 from rust-lang/rustc-pull

d40530b

Rustc pull update

Merge pull request rust/rustc-dev-guide#2814 from erfanio/main

a43992e

Update neovim instructions for neovim 0.11+

Update link for Rust reference documentation

72b21f4

Merge pull request rust-lang/rustc-dev-guide#2836 from reddevilmidzy/rr

e2bb6fc

Update link for Rust reference documentation

effects.md: update const trait syntax

873d2f6

`~const` was replaced with `[const]`, making uses of the former confusing

Merge pull request rust-lang#2838 from DanielEScherzer/patch-1

872a1c3

effects.md: update const trait syntax

rustdoc: fix a few spots where emit isn't respected

de48fc6

Clarifications and instructions - nightly

c5e1f60

- Only latest nightly crates' docs are published - How to get an old nightly docs

Typo in crate name

9faee77

PR review: use better command

369969a

rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Apr 22, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2026

rust-bors Bot merged commit 913e4be into rust-lang:main Apr 22, 2026
13 checks passed

rustbot added this to the 1.97.0 milestone Apr 22, 2026

rustbot added the perf-regression Performance regression. label Apr 22, 2026

Uh oh!

Conversation

JonathanBrouwer commented Apr 22, 2026

Uh oh!

JonathanBrouwer commented Apr 22, 2026

Uh oh!

rust-bors Bot commented Apr 22, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Apr 22, 2026

Uh oh!

rust-bors Bot commented Apr 22, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 22, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Apr 22, 2026

Uh oh!

rust-timer commented Apr 22, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

nnethercote commented Apr 22, 2026

Uh oh!

rust-timer commented Apr 22, 2026

Uh oh!

nnethercote commented Apr 23, 2026

Uh oh!

Kobzol commented Apr 23, 2026

Uh oh!

rust-timer commented Apr 23, 2026

Uh oh!

lqd commented Apr 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants