Skip to content

Fix get_child_at_index return type hints #155685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Apr 24, 2026
+19 −19
Merged

Fix get_child_at_index return type hints #155685

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 19 additions & 19 deletions src/etc/lldb_providers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from __future__ import annotations
import sys
from typing import Generator, List, TYPE_CHECKING
from typing import Generator, List, TYPE_CHECKING, Optional

from lldb import (
SBData,
Expand Down Expand Up @@ -112,7 +112,7 @@ def get_child_index(self, name: str) -> int:
return self.valobj.Dereference().GetSyntheticValue()
return self.valobj.GetIndexOfChildWithName(name)

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
return self.valobj.GetChildAtIndex(index)

def update(self):
Expand All @@ -137,7 +137,7 @@ def get_child_index(self, name: str) -> int:
return 0
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
if index == 0:
return self.valobj.Dereference().GetSyntheticValue()
return None
Expand All @@ -164,7 +164,7 @@ def num_children(self) -> int:
def get_child_index(self, name: str) -> int:
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
return None

def update(self):
Expand Down Expand Up @@ -425,7 +425,7 @@ def num_children(self) -> int:
def get_child_index(self, name: str) -> int:
return self.fields.get(name, -1)

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
if self.is_variant:
field = self.type.GetFieldAtIndex(index + 1)
else:
Expand Down Expand Up @@ -470,7 +470,7 @@ def get_child_index(self, name: str) -> int:

return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
if not 0 <= index < self.length:
return None
start = self.data_ptr.GetValueAsUnsigned()
Expand Down Expand Up @@ -506,7 +506,7 @@ def get_child_index(self, name: str) -> int:

return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
if not 0 <= index < self.length:
return None
start = self.data_ptr.GetValueAsUnsigned()
Expand Down Expand Up @@ -562,7 +562,7 @@ def num_children(self) -> int:
def get_child_index(self, name: str) -> int:
return self.value.GetIndexOfChildWithName(name)

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
return self.value.GetChildAtIndex(index)

def update(self):
Expand Down Expand Up @@ -768,7 +768,7 @@ def num_children(self) -> int:
def get_child_index(self, name: str) -> int:
return self.value.GetIndexOfChildWithName(name)

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
return self.value.GetChildAtIndex(index)

def has_children(self) -> bool:
Expand Down Expand Up @@ -858,7 +858,7 @@ def get_child_index(self, name: str) -> int:
else:
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
if self.is_variant:
field = self.type.GetFieldAtIndex(index + 1)
else:
Expand Down Expand Up @@ -887,7 +887,7 @@ def num_children(self) -> int:
def get_child_index(self, name: str) -> int:
return self.valobj.GetIndexOfChildWithName(name)

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
child: SBValue = self.valobj.GetChildAtIndex(index)
offset = self.valobj.GetType().GetFieldAtIndex(index).byte_offset
return self.valobj.CreateChildAtOffset(str(index), offset, child.GetType())
Expand Down Expand Up @@ -935,7 +935,7 @@ def get_child_index(self, name: str) -> int:
else:
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
start = self.data_ptr.GetValueAsUnsigned()
address = start + index * self.element_type_size
element = self.data_ptr.CreateValueFromAddress(
Expand Down Expand Up @@ -983,7 +983,7 @@ def get_child_index(self, name: str) -> int:
else:
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
start = self.data_ptr.GetValueAsUnsigned()
address = start + index * self.element_size
element = self.data_ptr.CreateValueFromAddress(
Expand Down Expand Up @@ -1047,7 +1047,7 @@ def get_child_index(self, name: str) -> int:
else:
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
start = self.data_ptr.GetValueAsUnsigned()
address = start + ((index + self.head) % self.cap) * self.element_type_size
element = self.data_ptr.CreateValueFromAddress(
Expand Down Expand Up @@ -1106,7 +1106,7 @@ def get_child_index(self, name: str) -> int:
else:
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
# logger = Logger.Logger()
start = self.data_ptr.GetValueAsUnsigned() & ~1

Expand Down Expand Up @@ -1195,7 +1195,7 @@ def get_child_index(self, name: str) -> int:
else:
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
pairs_start = self.data_ptr.GetValueAsUnsigned()
idx = self.valid_indices[index]
if self.new_layout:
Expand Down Expand Up @@ -1318,7 +1318,7 @@ def get_child_index(self, name: str) -> int:
return 2
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
if index == 0:
return self.value
if index == 1:
Expand Down Expand Up @@ -1351,7 +1351,7 @@ def get_child_index(self, name: str) -> int:
return 0
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
if index == 0:
return self.value
return None
Expand Down Expand Up @@ -1406,7 +1406,7 @@ def get_child_index(self, name: str) -> int:
return 1
return -1

def get_child_at_index(self, index: int) -> SBValue:
def get_child_at_index(self, index: int) -> Optional[SBValue]:
if index == 0:
return self.value
if index == 1:
Expand Down
Loading