Lint doc comments in cfg_select branches#155734
Open
qaijuang wants to merge 2 commits intorust-lang:mainfrom
Open
Lint doc comments in cfg_select branches#155734qaijuang wants to merge 2 commits intorust-lang:mainfrom
qaijuang wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-attributes
qaijuang
force-pushed
the
cfg-select-doc-comment
branch
from
fb8cf2e to
9c49112
Compare
folkertdev
reviewed
Apr 24, 2026
Co-authored-by: Copilot <copilot@github.com>
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @JonathanBrouwer. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
|
||
| let tts = p.parse_delimited_token_tree().map_err(|e| e.emit())?; | ||
| let span = underscore.span.to(p.token.span); | ||
| lint_unused_doc_comment(p, doc_comment, lint_node_id); |
Contributor
There was a problem hiding this comment.
Why is the lint_unused_doc_comment here rather than immediately after the eat_outer_doc_comments call?
JonathanBrouwer
requested changes
Apr 25, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155701.