Rollup of 12 pull requests by JonathanBrouwer · Pull Request #155745 · rust-lang/rust

JonathanBrouwer · 2026-04-24T16:19:22Z

Successful merges:

Refactor out common code into a IndexItem::new constructor #149452 (Refactor out common code into a IndexItem::new constructor)
Document #[diagnostic::on_move] in the unstable book. #155621 (Document #[diagnostic::on_move] in the unstable book.)
delegation: rename Self generic param to This in recursive delegations #155635 (delegation: rename Self generic param to This in recursive delegations)
Some cleanups around per parent disambiguators #155730 (Some cleanups around per parent disambiguators)
rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu #153537 (rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu)
Do not suggest borrowing enclosing calls for nested where-clause obligations #155219 (Do not suggest borrowing enclosing calls for nested where-clause obligations)
rustdoc: Fix Managarm C Library name in cfg pretty printer #155408 (rustdoc: Fix Managarm C Library name in cfg pretty printer)
Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf #155571 (Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf)
test: Add a regression test for Apple platforms aborting on free #155713 (test: Add a regression test for Apple platforms aborting on free)
Fix tier level for 5 thumb bare-metal ARM targets #155723 (Fix tier level for 5 thumb bare-metal ARM targets)
Fix typo by removing extra 'to' #155735 (Fix typo by removing extra 'to')
Remove AllVariants workaround for rust-analyzer #155736 (Remove AllVariants workaround for rust-analyzer)

…gations

…own-linux-gnueabihf Add SanitizerSet::ADDRESS to the supported_sanitizers for the arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf targets. The AddressSanitizer is already enabled on the armv7-linux-androideabi platform, which shares the same ARM architecture. There is no reason these Linux GNU targets should not also support it, as the underlying LLVM support for ASan on 32-bit ARM is already in place.

Add a regression test for RUST-150898 to make users aware that if this test fails, they may encounter unusual behavior elsewhere. Original repro authored by dianqk.

So we do not need to disambiguate considering parents

…the same parent

…, r=notriddle,lolbinarycat Refactor out common code into a `IndexItem::new` constructor rust-lang#149404

@estebank

… r=chenyukang Document #[diagnostic::on_move] in the unstable book. Also adds the attribute on `std::fs::File` to stay consistent with the prose in the unstable book entry. cc @estebank @rperier Rendered: <img width="791" height="903" alt="image" src="https://github.com/user-attachments/assets/a27a5211-7717-4f7f-a514-8316dccc78d5" /> <img width="779" height="390" alt="image" src="https://github.com/user-attachments/assets/a983108d-575e-4551-ab14-28611344e9b0" />

@petrochenkov

…-rename, r=petrochenkov delegation: rename `Self` generic param to `This` in recursive delegations This PR supports renaming of `Self` generic parameter to `This` in recursive delegations scenario, this allows propagation of `This` as we rely on `Self` naming to check whether it is implicit Self of a trait. Comment with a bit deeper explanation is in `uplift_delegation_generic_params`. Part of rust-lang#118212. r? @petrochenkov

@petrochenkov

Some cleanups around per parent disambiguators r? @petrochenkov follow-up to rust-lang#155547 The two remaining uses are * resolve_bound_vars, where it is a reasonable way to do it instead of having another field in the visitor that needs to get scoped (set & reset) every time we visit an opaque type. May still change that at some point, but it's not really an issue * `create_def` in the resolver: will get removed together with my other refactorings for `node_id_to_def_id` (making that per-owner)

@glaubitz

…iser rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu Currently, attempting to build this target using Ubuntu/Debian's sparc64-multilib toolchain results in the following link error ([full log](https://github.com/taiki-e/atomic-maybe-uninit/actions/runs/22798868888/job/66137493862#step:15:442)): ``` = note: /usr/lib/gcc-cross/sparc64-linux-gnu/13/../../../../sparc64-linux-gnu/bin/ld: unknown architecture of input file `/home/runner/work/atomic-maybe-uninit/atomic-maybe-uninit/target/sparc-unknown-linux-gnu/debug/deps/rustcYzaDYW/symbols.o' is incompatible with sparc:v8plus output ``` This appears to be caused by the required e_flag being missing and can be fixed by setting `EF_SPARC_32PLUS`. Tested using rustc with this patch applied and qemu-user (taiki-e/atomic-maybe-uninit@57d7e7f, [log](https://github.com/taiki-e/atomic-maybe-uninit/actions/runs/22798793270/job/66137298093)). Related discussion: rust-lang#131222 (comment) r? workingjubilee cc @glaubitz @rustbot label +O-SPARC

…w-suggestion-v2, r=JohnTitor Do not suggest borrowing enclosing calls for nested where-clause obligations In rust-lang#155088, the compiler was blaming the whole call expr instead of the value that actually failed the trait bound, so for foo(&[String::from("a")]) it was suggesting stuff like &foo(...). I changed the suggestion logic so it only emits borrow help if the expr it found actually matches the failed self type, and used the same check for the “similar impl exists” help too. So now the compiler should give the normal error + required bound note. Fix rust-lang#155088

…inarycat rustdoc: Fix Managarm C Library name in cfg pretty printer Like rust-lang#155293, this was introduced in rust-lang#154328. Unlike that PR, I don't think there's any need to backport, because this cfg is not used anywhere in the standard library. (I searched for `"mlibc"`, the only place it's used in rust-lang/rust is the HTML doc test.) #### Other Minor Fixes Remove a FIXME comment in the pretty printer, `os = "none"` is always bare metal: https://github.com/rust-lang/rust/blob/d227e48c560e915fe7c0b8b3e821680a3a0ba739/compiler/rustc_target/src/spec/mod.rs#L3179 Fix a comment typo, ignore another typo in vendored sources.

Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf Add SanitizerSet::ADDRESS to the supported_sanitizers for the arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf targets. The AddressSanitizer is already enabled on the armv7-linux-androideabi platform, which shares the same ARM architecture. There is no reason these Linux GNU targets should not also support it, as the underlying LLVM support for ASan on 32-bit ARM is already in place.

…=dianqk test: Add a regression test for Apple platforms aborting on `free` Add a regression test for rust-lang#150898 to make users aware that if this test failures, they may encounter unusual behavior elsewhere.

…c, r=wesleywiser Fix tier level for 5 thumb bare-metal ARM targets The spec files for 5 Thumb-mode bare-metal ARM targets incorrectly set tier: Some(2), while the documentation correctly lists them as Tier 3. This mismatch was introduced in PR rust-lang#150556 — the intent was Tier 2 eventually, but these targets should sit at Tier 3 until a proper Tier 3 → Tier 2 promotion MCP is submitted and approved. This PR changes tier: Some(2) → Some(3) in the following spec files, making them consistent with the docs: thumbv7a-none-eabi thumbv7a-none-eabihf thumbv7r-none-eabi thumbv7r-none-eabihf thumbv8r-none-eabihf PS: No doc changes needed — they already correctly state Tier 3. r?

…typo, r=wesleywiser Fix typo by removing extra 'to' Fixes rust-lang#155695 Fix a typo in the `std::convert` module documentation by removing an extra "to" in the module-level docs.

…chenkov Remove `AllVariants` workaround for rust-analyzer Part of rust-lang#155677 Removes the `ALL_VARIANTS` alias added to work around rust-analyzer not supporting `#![feature(macro_derive)]`, which has since been fixed (rust-lang/rust-analyzer/issues/21043).

JonathanBrouwer · 2026-04-24T16:19:34Z

@bors r+ rollup=never p=5

rust-bors · 2026-04-24T16:19:37Z

📌 Commit 2a885bb has been approved by JonathanBrouwer

It is now in the queue for this repository.

…uwer Rollup of 12 pull requests Successful merges: - #149452 (Refactor out common code into a `IndexItem::new` constructor) - #155621 (Document #[diagnostic::on_move] in the unstable book.) - #155635 (delegation: rename `Self` generic param to `This` in recursive delegations) - #155730 (Some cleanups around per parent disambiguators) - #153537 (rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu) - #155219 (Do not suggest borrowing enclosing calls for nested where-clause obligations) - #155408 (rustdoc: Fix Managarm C Library name in cfg pretty printer) - #155571 (Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf) - #155713 (test: Add a regression test for Apple platforms aborting on `free`) - #155723 (Fix tier level for 5 thumb bare-metal ARM targets) - #155735 (Fix typo by removing extra 'to') - #155736 (Remove `AllVariants` workaround for rust-analyzer)

rust-bors · 2026-04-24T17:19:06Z

💔 Test for cfaac75 failed: CI. Failed job:

auto - dist-x86_64-illumos (web logs, enhanced plaintext logs)

rust-log-analyzer · 2026-04-24T17:25:14Z

The job dist-x86_64-illumos failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[222/3898] Building CXX object lib/CAS/CMakeFiles/LLVMCAS.dir/BuiltinUnifiedCASDatabases.cpp.o
[223/3898] Building CXX object lib/CAS/CMakeFiles/LLVMCAS.dir/InMemoryCAS.cpp.o
[224/3898] Building CXX object lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o
FAILED: lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o 
sccache /usr/bin/c++ -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Demangle -I/checkout/src/llvm-project/llvm/lib/Demangle -Iinclude -I/checkout/src/llvm-project/llvm/include -ffunction-sections -fdata-sections -fPIC -m64 -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -w -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fno-exceptions -funwind-tables -fno-rtti -std=c++1z -MD -MT lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o -MF lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o.d -o lib/Demangle/CMakeFiles/LLVMDemangle.dir/MicrosoftDemangle.cpp.o -c /checkout/src/llvm-project/llvm/lib/Demangle/MicrosoftDemangle.cpp
sccache: error: Timed out waiting for server startup. Maybe the remote service is unreachable?
Run with SCCACHE_LOG=debug SCCACHE_NO_DAEMON=1 to get more information
[225/3898] Building CXX object lib/CAS/CMakeFiles/LLVMCAS.dir/MappedFileRegionArena.cpp.o
[226/3898] Building CXX object lib/CAS/CMakeFiles/LLVMCAS.dir/ObjectStore.cpp.o
[227/3898] Building CXX object lib/CAS/CMakeFiles/LLVMCAS.dir/OnDiskCAS.cpp.o
ninja: build stopped: subcommand failed.

---
   0: __rustc::rust_begin_unwind
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/std/src/panicking.rs:689:5
   1: core::panicking::panic_fmt
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/core/src/panicking.rs:80:14
   2: cmake::fail
   3: cmake::run
   4: <cmake::Config>::build
   5: <bootstrap::core::build_steps::llvm::Llvm as bootstrap::core::builder::Step>::run
             at /checkout/src/bootstrap/src/core/build_steps/llvm.rs:553:13
   6: <bootstrap::core::builder::Builder>::ensure::<bootstrap::core::build_steps::llvm::Llvm>
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1579:36
   7: <bootstrap::core::build_steps::llvm::Llvm as bootstrap::core::builder::Step>::run
             at /checkout/src/bootstrap/src/core/build_steps/llvm.rs:500:25
---
  11: <bootstrap::core::builder::Builder>::compiler
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1149:14
  12: <bootstrap::core::build_steps::dist::Rustc as bootstrap::core::builder::Step>::make_run
             at /checkout/src/bootstrap/src/core/build_steps/dist.rs:495:42
  13: <bootstrap::core::builder::StepDescription>::maybe_run
             at /checkout/src/bootstrap/src/core/builder/mod.rs:476:13
  14: bootstrap::core::builder::cli_paths::match_paths_to_steps_and_run
             at /checkout/src/bootstrap/src/core/builder/cli_paths.rs:141:22
  15: <bootstrap::core::builder::Builder>::run_step_descriptions
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1122:9
  16: <bootstrap::core::builder::Builder>::execute_cli
             at /checkout/src/bootstrap/src/core/builder/mod.rs:1101:14
  17: <bootstrap::Build>::build
             at /checkout/src/bootstrap/src/lib.rs:799:25
  18: bootstrap::main
             at /checkout/src/bootstrap/src/bin/main.rs:130:11
  19: <fn() as core::ops::function::FnOnce<()>>::call_once
             at /rustc/ef0fb8a2563200e322fa4419f09f65a63742038c/library/core/src/ops/function.rs:250:5

JonathanBrouwer · 2026-04-24T17:30:05Z

Probably spurious?
@bors retry

rust-bors · 2026-04-24T17:30:33Z

⌛ Testing commit 2a885bb with merge 7c61a35...

Workflow: https://github.com/rust-lang/rust/actions/runs/24902982972

…uwer Rollup of 12 pull requests Successful merges: - #149452 (Refactor out common code into a `IndexItem::new` constructor) - #155621 (Document #[diagnostic::on_move] in the unstable book.) - #155635 (delegation: rename `Self` generic param to `This` in recursive delegations) - #155730 (Some cleanups around per parent disambiguators) - #153537 (rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu) - #155219 (Do not suggest borrowing enclosing calls for nested where-clause obligations) - #155408 (rustdoc: Fix Managarm C Library name in cfg pretty printer) - #155571 (Enable AddressSanitizer on arm-unknown-linux-gnueabihf and armv7-unknown-linux-gnueabihf) - #155713 (test: Add a regression test for Apple platforms aborting on `free`) - #155723 (Fix tier level for 5 thumb bare-metal ARM targets) - #155735 (Fix typo by removing extra 'to') - #155736 (Remove `AllVariants` workaround for rust-analyzer)

taiki-e and others added 28 commits March 7, 2026 21:53

rustc_codegen_ssa: Define ELF flag value for sparc-unknown-linux-gnu

e0d9940

Do not suggest borrowing enclosing calls for nested where-clause obli…

9064d17

…gations

Put #[diagnostic::on_move] on File

70cf3f4

Separate out some IndexItem fields into a new struct and DRY

ab1500b

Fix Mlibc env pretty print to Managarm C Library

c0441d4

Resolve FIXME: os = none is bare metal

140dad0

Fix some typos

34c0fe8

Document #[diagnostic::on_move] in the unstable book

ce880a4

Rename Self generic param to This in recursive delegations

7f2a98d

Fix tier level for 5 thumb bare-metal ARM targets

27e12b8

test: Add a regression test for Apple platforms aborting on free

150905c

Add a regression test for RUST-150898 to make users aware that if this test fails, they may encounter unusual behavior elsewhere. Original repro authored by dianqk.

All nested statics in a single interning run have the same parent

e90878b

So we do not need to disambiguate considering parents

All generated associated types for opaque types in traits/impls have …

bfb085d

…the same parent

Fix typo by removing extra 'to'

52b93e0

Remove AllVariants workaround for rust-analyzer

ece632c

Rollup merge of rust-lang#149452 - yotamofek:pr/rustdoc/IndexItem-new…

d4a700a

…, r=notriddle,lolbinarycat Refactor out common code into a `IndexItem::new` constructor rust-lang#149404

Rollup merge of rust-lang#155735 - Muhtasim-Rasheed:issue-155695-fix-…

4eaa44b

…typo, r=wesleywiser Fix typo by removing extra 'to' Fixes rust-lang#155695 Fix a typo in the `std::convert` module documentation by removing an extra "to" in the module-level docs.

rust-bors Bot added the rollup A PR which is a rollup label Apr 24, 2026

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 24, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 24, 2026

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2026

rust-bors Bot mentioned this pull request Apr 24, 2026

Refactor out common code into a IndexItem::new constructor #149452

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 12 pull requests#155745

Rollup of 12 pull requests#155745
JonathanBrouwer wants to merge 28 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-D6OSAOt

JonathanBrouwer commented Apr 24, 2026

Uh oh!

JonathanBrouwer commented Apr 24, 2026

Uh oh!

rust-bors Bot commented Apr 24, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Apr 24, 2026

Uh oh!

rust-log-analyzer commented Apr 24, 2026

Uh oh!

JonathanBrouwer commented Apr 24, 2026

Uh oh!

rust-bors Bot commented Apr 24, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Uh oh!

Conversation

JonathanBrouwer commented Apr 24, 2026

Uh oh!

JonathanBrouwer commented Apr 24, 2026

Uh oh!

rust-bors Bot commented Apr 24, 2026

Uh oh!

This comment has been minimized.

rust-bors Bot commented Apr 24, 2026

Uh oh!

rust-log-analyzer commented Apr 24, 2026

Uh oh!

JonathanBrouwer commented Apr 24, 2026

Uh oh!

rust-bors Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

rust-bors Bot commented Apr 24, 2026 •

edited

Loading