-Znext-solver Eager normalization outside of solver #155767
Draft
adwinwhite wants to merge 9 commits intorust-lang:mainfrom
Draft
-Znext-solver Eager normalization outside of solver #155767adwinwhite wants to merge 9 commits intorust-lang:mainfrom
-Znext-solver Eager normalization outside of solver #155767adwinwhite wants to merge 9 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
Member
|
does this fix #151308 ? |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
Yes, it probably fixes a bunch of issues. And unfix some issues fixed by the next solver? Unsure about that. |
adwinwhite
force-pushed
the
eager-norm-outside
branch
from
34677fc to
e4b9746
Compare
Contributor
Author
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. @rustbot label: +S-waiting-on-perf |
Contributor
|
⌛ Trying commit e4b9746 with merge 59cc905… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/24928820877 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Apr 25, 2026
`-Znext-solver` Eager normalization outside of solver
rustbot
added
the
S-waiting-on-perf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a normalization routine for the next solver that behaves the same as the normalization in the old solver.
And it's used to normalize eagerly outside of the next solver.
This is part 2 of modifying the next solver to support eager normalization.
Those test changes are all wording changes, duplicating some errors or reducing some duplicates. But I could have overlooked something.
Notably it fixes the first example of rust-lang/trait-system-refactor-initiative#191, but not the remaining cases.
It's probably easier to review commit by commit.
WIP: maybe remove old
deeply_normalizer? @ghost