Suggest [const] Trait bounds in more places#155861
Open
oli-obk wants to merge 2 commits intorust-lang:mainfrom
Open
Suggest [const] Trait bounds in more places#155861oli-obk wants to merge 2 commits intorust-lang:mainfrom
[const] Trait bounds in more places#155861oli-obk wants to merge 2 commits intorust-lang:mainfrom
Conversation
Collaborator
|
rustbot has assigned @jdonszelmann. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we have some special logic in the const checker for emitting
[const] Traitsuggestions, but I'm trying to handle that similarly to how it is handled for normalTraitclauses. This is just a small step in how it will look on the UX side, which should make my follow-up PRs affect tests less and just be a refactoring