Fix cross-compiling macos-deployment-target-warning test#155870
Open
madsmtm wants to merge 1 commit intorust-lang:mainfrom
Open
Fix cross-compiling macos-deployment-target-warning test#155870madsmtm wants to merge 1 commit intorust-lang:mainfrom
macos-deployment-target-warning test#155870madsmtm wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
madsmtm
force-pushed
the
fix-test-arm64e
branch
from
5f46482 to
24ec73d
Compare
`cc()` gets target flags, which won't match with the host triple used by `bare_rustc()`.
madsmtm
force-pushed
the
fix-test-arm64e
branch
from
24ec73d to
3be45b3
Compare
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc()gets target flags, which won't match with the host triple used bybare_rustc().Follow-up to #155716, with both of these,
./x test --target arm64e-apple-darwin testsnow succeeds.r? compiler