Avoid misleading return-type note for foreign Fn callees#155877
Open
qaijuang wants to merge 1 commit intorust-lang:mainfrom
Open
Avoid misleading return-type note for foreign Fn callees#155877qaijuang wants to merge 1 commit intorust-lang:mainfrom
Fn callees#155877qaijuang wants to merge 1 commit intorust-lang:mainfrom
Conversation
Contributor
Author
Collaborator
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155727.
The issue occurred because the code that emitted the
Fn/FnMutsuggestion only avoided the return-type fallback when it could point at a local callee argument. The local case from #125325 was fixed in #126226, but nested cross-crate cases could still suggest changing the enclosing function's return type even though the relevantFnrequirement came from the callee argument.This is also the broader diagnostic shape discussed in #119985.
This PR checks the instantiated callee predicates for an exact
Fnboundon the closure argument, and extends
wrong-closure-arg-suggestion-125325with cross-crate function and method cases for that path.