ssa_range_prop: avoid ICE on self-loop successors#155891
Open
SixEternals wants to merge 1 commit intorust-lang:mainfrom
Open
ssa_range_prop: avoid ICE on self-loop successors#155891SixEternals wants to merge 1 commit intorust-lang:mainfrom
SixEternals wants to merge 1 commit intorust-lang:mainfrom
Conversation
loops Replace self-loop assumptions in ssa_range_prop terminator handling with guards that skip range insertion when successor is in the same block. Add a UI regression test for issue rust-lang#155836 to ensure optimized builds no longer ICE. Fixes rust-lang#155836 Constraint: Keep propagation behavior unchanged for non- self-loop edges Rejected: Keep assert_ne! and special-case only Assert arm | still leaves SwitchInt self-loop paths vulnerable Confidence: high Scope-risk: narrow Reversibility: clean Directive: Do not reintroduce block-inequality assertions in terminator propagation without proving CFG invariants after simplification Tested: ./x.py check compiler/rustc_mir_transform; ./x.py test tests/ui/mir/ssa-range-prop-self-loop-155836.rs Not-tested: Broader SwitchInt multi-target stress cases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155836.
Replace block-inequality assertions in
ssa_range_propterminator handlingwith guards that skip propagation for self-loop successors.
Added regression test:
tests/ui/mir/ssa-range-prop-self-loop-155836.rs(
-C opt-level=2,check-pass).Validation commands: