Skip to content

Refer to FnDef as "function item", not "function pointer"#155900

Open
theemathas wants to merge 1 commit intorust-lang:mainfrom
theemathas:fndef-is-function-item
Open

Refer to FnDef as "function item", not "function pointer"#155900
theemathas wants to merge 1 commit intorust-lang:mainfrom
theemathas:fndef-is-function-item

Conversation

@theemathas
Copy link
Copy Markdown
Contributor

@theemathas theemathas commented Apr 28, 2026

No description provided.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 28, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 28, 2026

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 19 candidates

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 28, 2026

r? me

@bors r+ rollu

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 28, 2026

📌 Commit 6f2e501 has been approved by Kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 28, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 28, 2026
@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented Apr 28, 2026

@bors rollup

jhpratt added a commit to jhpratt/rust that referenced this pull request Apr 28, 2026
@jhpratt
Rollup merge of rust-lang#155900 - theemathas:fndef-is-function-item,…
6960391 
… r=Kivooeo

Refer to `FnDef` as "function item", not "function pointer"
@jhpratt jhpratt mentioned this pull request Apr 28, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request Apr 28, 2026
@bors
Auto merge of #155901 - jhpratt:rollup-R3JaeoO, r=jhpratt
b806d39 
Rollup of 3 pull requests

Successful merges:

 - #155894 (triagebot: add myself to libs rotation)
 - #155897 (Add regression test for LLVM bug with huge stack frames)
 - #155900 (Refer to `FnDef` as "function item", not "function pointer")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kivooeo Kivooeo

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@theemathas @rustbot @Kivooeo @mejrs