ci(free-disk-space): remove more tools and fix warnings#155958
Open
marcoieni wants to merge 1 commit intorust-lang:mainfrom
Open
ci(free-disk-space): remove more tools and fix warnings#155958marcoieni wants to merge 1 commit intorust-lang:mainfrom
marcoieni wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-CI
marcoieni
commented
Apr 29, 2026
| # Remove Docker images. | ||
| # Ubuntu 22 runners have docker images already installed. | ||
| # They aren't present in ubuntu 24 runners. | ||
| # Remove preinstalled Docker images. |
Member
Author
There was a problem hiding this comment.
Removed this comment because there are some docker images in ubuntu 24 as well.
marcoieni
changed the title
marcoieni
force-pushed
the
ci-remove-edge-chrome-and-more
branch
from
5a7dd95 to
e5493ea
Compare
marcoieni
commented
Apr 29, 2026
| ) | ||
|
|
||
| # Paths only present in x86 runners | ||
| local github_runner_x86_paths=( |
Member
Author
There was a problem hiding this comment.
I extracted these paths from the array above because they are not present in arm. Trying to remove them was emitting a warning.
marcoieni
commented
Apr 29, 2026
| ) | ||
| local x86_only_packages=( | ||
| 'google-chrome-stable' | ||
| 'microsoft-edge-stable' |
Member
Author
There was a problem hiding this comment.
edge and the new packages from temurin to skopeo are new (they weren't removed before)
marcoieni
commented
Apr 29, 2026
Comment on lines
+136
to
+140
| # Microsoft Edge and powershell | ||
| "/opt/microsoft" | ||
|
|
||
| "/opt/pipx" | ||
| "/opt/pipx_bin" |
Member
Author
There was a problem hiding this comment.
These paths are new
marcoieni
commented
Apr 29, 2026
| if [ -z "$images" ]; then | ||
| echo "=> No docker images to remove." | ||
| return | ||
| fi |
Member
Author
There was a problem hiding this comment.
Attempting to remove all docker images when there were none, produced a warning (because the measured saved space was less than zero)
marcoieni
commented
Apr 29, 2026
| sufficientSpaceEarlyExit() { | ||
| local available_space_kb=$(df -k . --output=avail | tail -n 1) | ||
| local available_space_kb | ||
| available_space_kb=$(df -k . --output=avail | tail -n 1) |
Member
Author
There was a problem hiding this comment.
here and below I fixed a shellcheck lint that suggested to declare the variable before assigning it
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
S-waiting-on-author
Member
Author
The CI was successful, I'm reverting the commit 86529fb
|
marcoieni
force-pushed
the
ci-remove-edge-chrome-and-more
branch
from
86529fb to
e5493ea
Compare
rustbot
added
S-waiting-on-review
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR I remove more space and improve the free-disk-space-linux script.
If you prefer me to split this PR into multiple ones, let me know.
Discussed in #t-infra > some jobs running out of disk space
Test
I tested this change in marcoieni/actions-test@196ce70. As you can see the workflows run without warnings, which ensures that we can remove all the space possible from the arm runners.
I also tested this change in this repository, by commenting out the mechanism to skip disk cleanup in case there is sufficient available disk space. ( see 86529fb )
If I don't comment out the code, it can happen that the CI skips the code I edited because there's enough disk space in the runners that this CI is running.
Here's the change of that commit:
Storage saved
In that temporary commit, I measured how much we are saving. It looks like this PR saves ~2GB:
Total saved: Saved 35GiBTotal saved: Saved 37GiB