Deny warnings in the test for crates that are available on stable#155961
Open
jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
Open
Deny warnings in the test for crates that are available on stable#155961jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
jdonszelmann wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
A-run-make
jdonszelmann
changed the title
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
r? @mejrs rustbot has assigned @mejrs. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
bjorn3
reviewed
Apr 29, 2026
| #[cfg(feature = "nightly")] | ||
| macro_rules! generate { ($( $tt:tt )*) => { $( $tt )* } } | ||
|
|
||
| /// For early binders, you should first call `instantiate` before using any visitors. |
Member
There was a problem hiding this comment.
This should be inside the generate!() to add docs to the impl, right? Also maybe you can merge both generate!() calls together to avoid duplicating the cfg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've got a couple of crates, like
rustc_type_irthat have parts disabled on stable. I believe part of this is so, for example, rust-analyzer can use bits of the compiler. We previously allowed warnings here, and I ran into one. This denies warnings in the test that compiles these stable crates (I chose not to on the crate itself, so you don't constantly run into the warnings if you have turned that off inconfig.toml). This test doesn't run by default, but it does run in CI.