tests/run-make/print-cfg: add Android target_env case#155988
Open
Vastargazing wants to merge 1 commit intorust-lang:mainfrom
Open
tests/run-make/print-cfg: add Android target_env case#155988Vastargazing wants to merge 1 commit intorust-lang:mainfrom
Vastargazing wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-run-make
This comment has been minimized.
This comment has been minimized.
Android targets must not inherit `target_env="gnu"` from the Linux GNU base. Cover this in the existing print-cfg run-make test so a future target-spec refactor cannot silently re-introduce it.
Vastargazing
force-pushed
the
tests/android-target-env-print-cfg
branch
from
40064e2 to
ef93fbb
Compare
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for #90834
#77729 + #78929 accidentally gave Android targets
target_env="gnu"through
android_baseinheriting fromlinux_gnu_base. #90834 moved itback to plain
linux_basebut didn't add a test, so a future target-specrefactor could bring it back unnoticed. This adds an Android case to
tests/run-make/print-cfgcovering exactly that.r? @petrochenkov