[rustdoc] Fix doc_cfg feature on reexports#156073
Open
GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
Open
[rustdoc] Fix doc_cfg feature on reexports#156073GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
doc_cfg feature on reexports#156073GuillaumeGomez wants to merge 2 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Urgau
reviewed
May 2, 2026
Comment on lines
+12
to
+13
| //@has 'foo/struct.SubBanana.html' | ||
| //@has - '//*[@class="item-info"]/*[@class="stab portability"]' 'Available on non-crate feature ananas and non-crate feature banana only.' |
Member
There was a problem hiding this comment.
For SubBanana, isn't the stability missing not(feature = "yoyo")? With this PR it only talks about ananas and banana, but it's exported via:
#[cfg(not(feature = "yoyo"))]
pub use self::banana::*;so I think we should mention not(feature = "yoyo").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #150268.
I don't mark the issue as fixed as I need to check the third case described in the issue. First commit comes from #156020, will need to rebase this PR once the original is merged.
r? @Urgau