[POC] create an MVP for using Destruct for custom dtors#156090
Draft
JayanAXHF wants to merge 2 commits intorust-lang:mainfrom
Draft
[POC] create an MVP for using Destruct for custom dtors#156090JayanAXHF wants to merge 2 commits intorust-lang:mainfrom
Destruct for custom dtors#156090JayanAXHF wants to merge 2 commits intorust-lang:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
13224fe to
e48ef91
Compare
This comment has been minimized.
This comment has been minimized.
e48ef91 to
30d34f8
Compare
This comment has been minimized.
This comment has been minimized.
30d34f8 to
1a1e29a
Compare
This comment has been minimized.
This comment has been minimized.
1a1e29a to
74b13aa
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
welp i have no idea what this is. Is this due to smth with cg_clift? do i need to make changes there |
Member
Author
|
fixed it i think, it was related to the minicores not being updated |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Destruct::drop_in_placeinstead ofmem::ptr::drop_in_place.DestructDropInPlacecandidate_assembly, and only checks for builtin impl when it doesnt find oneassemble_builtin_impl_candidatescc: @Nadrieril and @oli-obk (you were interested in reviewing this from the PG)
Note that this is a POC and i've not ironed out the comments and im not 100% confident that this is the best way to do this.
r? ghost