change field tools on AttributeParser to hold &'tcx RegisteredTools#156091
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom May 3, 2026
Merged
change field tools on AttributeParser to hold &'tcx RegisteredTools#156091rust-bors[bot] merged 1 commit intorust-lang:mainfrom
tools on AttributeParser to hold &'tcx RegisteredTools#156091rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing cc @jdonszelmann, @JonathanBrouwer These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
rustbot
added
A-attributes
JonathanBrouwer
approved these changes
May 2, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
petrochenkov
reviewed
May 2, 2026
| rustc_feature = { path = "../rustc_feature" } | ||
| rustc_hir = { path = "../rustc_hir" } | ||
| rustc_lexer = { path = "../rustc_lexer" } | ||
| rustc_lint_defs = { path = "../rustc_lint_defs" } |
Contributor
There was a problem hiding this comment.
Note: this crate already depends on rustc_lint_defs indirectly through rustc_errors, so this is ok.
Contributor
There was a problem hiding this comment.
I know it doesn't matter but it feels somewhat silly when RegisteredTools is just a type alias.
Contributor
Author
There was a problem hiding this comment.
I know it doesn't matter but it feels somewhat silly when RegisteredTools is just a type alias.
I think it's worth it for more consistency and to avoid confusion
petrochenkov
approved these changes
May 2, 2026
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 2, 2026
change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools` Makes tools actually stored, and not just tool names this was originally part of rust-lang#155691 but was split out to make that PR smaller. r? @petrochenkov cc @JonathanBrouwer
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
May 2, 2026
change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools` Makes tools actually stored, and not just tool names this was originally part of rust-lang#155691 but was split out to make that PR smaller. r? @petrochenkov cc @JonathanBrouwer
rust-bors Bot
pushed a commit
that referenced
this pull request
May 3, 2026
…uwer Rollup of 5 pull requests Successful merges: - #152277 (Validate source snippet when format input is raw string) - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind) - #156079 (Move and rename the `clone-never.rs` test) - #156091 (change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools`)
rust-bors Bot
pushed a commit
that referenced
this pull request
May 3, 2026
Rollup of 5 pull requests Successful merges: - #155666 (Interning cleanups) - #155940 (refactor rustc_on_unimplemented's filtering) - #156065 (Remove unused spans from AttributeKind) - #156079 (Move and rename the `clone-never.rs` test) - #156091 (change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools`)
rust-timer
added a commit
that referenced
this pull request
May 3, 2026
Rollup merge of #156091 - Bryntet:move-tools, r=JonathanBrouwer change field `tools` on `AttributeParser` to hold `&'tcx RegisteredTools` Makes tools actually stored, and not just tool names this was originally part of #155691 but was split out to make that PR smaller. r? @petrochenkov cc @JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes tools actually stored, and not just tool names
this was originally part of #155691 but was split out to make that PR smaller.
r? @petrochenkov
cc @JonathanBrouwer