Skip to content

Add a doc_cfg regression test to ensure foreign types impls are working as expected#156122

Open
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
GuillaumeGomez:doc-cfg-test
Open

Add a doc_cfg regression test to ensure foreign types impls are working as expected#156122
GuillaumeGomez wants to merge 1 commit intorust-lang:mainfrom
GuillaumeGomez:doc-cfg-test

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

Fixes #150268.

This is the last case mentioned in the issue that wasn't tested. With this, the issue can be closed.

r? @Urgau

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels May 3, 2026
@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
............F.............................         (142/142)

======== tests/rustdoc-gui/sidebar.goml ========

[ERROR] line 208: `#sidebar-button a` not found: for command `assert-css: ("#sidebar-button a::before", {"content": |image_url|})`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/src/huge_logo/lib.rs.html#2-17>


<= doc-ui tests done: 141 succeeded, 1 failed, 0 filtered out

Error: ()

@GuillaumeGomez
Copy link
Copy Markdown
Member Author

Oh a flaky. It's been a long time. ^^'

@Urgau Urgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After doc_auto_cfg is gone, in the generated docs, nested structs do not receive the feature label anymore

4 participants