warn on empty precision, but only when width present#156143
Open
hkBst wants to merge 1 commit intorust-lang:mainfrom
Open
warn on empty precision, but only when width present#156143hkBst wants to merge 1 commit intorust-lang:mainfrom
hkBst wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworking of #136638.
Fixes #131159 by warning on missing precision only if there is a width specified.
This is the only case where a previous crater run caught a bug because "{:2.?}" was written but "{:.2?}" was meant.
r? @m-ou-se
Feel free to close if this is still deemed undesirable.