Better docs for PartialEq#156144
Open
hkBst wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @nia-e rustbot has assigned @nia-e. Use Why was this reviewer chosen?The reviewer was selected based on:
|
nia-e
requested changes
May 4, 2026
| fn eq(&self, other: &Rhs) -> bool; | ||
|
|
||
| /// Tests for `!=`. The default implementation is almost always sufficient, | ||
| /// and should not be overridden without very good reason. |
Member
There was a problem hiding this comment.
This warning should probably remain in some form
Member
Author
There was a problem hiding this comment.
I've now tried to reword to mention the few cases where it could make sense to override (line 269).
| /// Implements `PartialEq` for primitive types. | ||
| /// | ||
| /// Primitive types have a compiler-defined primitive implementation of `==` and `!=`. | ||
| /// This implements the `PartialEq` trait is terms of those primitive implementations. |
Member
There was a problem hiding this comment.
typo: "trait [in] terms of"
rustbot
added
S-waiting-on-author
Member
|
Looks mostly fine, just a few comments. Thanks! |
rust-cloud-vms
Bot
force-pushed
the
improve-partial-eq-docs
branch
from
a52171b to
d3db8b5
Compare
rust-cloud-vms
Bot
force-pushed
the
improve-partial-eq-docs
branch
from
d3db8b5 to
f25a255
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.