Use all_impls instead of handrolling it#156148
Open
oli-obk wants to merge 1 commit intorust-lang:mainfrom
Open
Use all_impls instead of handrolling it#156148oli-obk wants to merge 1 commit intorust-lang:mainfrom
all_impls instead of handrolling it#156148oli-obk wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
lqd
approved these changes
May 4, 2026
| .collect::<Vec<_>>(); | ||
| if !types.is_empty() { | ||
| let len = types.len(); | ||
| let post = if types.len() > 9 { |
Member
There was a problem hiding this comment.
might as well
Suggested change
| let post = if types.len() > 9 { | |
| let post = if len > 9 { |
| .collect::<Vec<_>>(); | ||
| if !types.is_empty() { | ||
| let len = types.len(); | ||
| let post = if types.len() > 9 { |
Member
There was a problem hiding this comment.
might as well
Suggested change
| let post = if types.len() > 9 { | |
| let post = if len > 9 { |
| .collect::<Vec<_>>(); | ||
| if !types.is_empty() { | ||
| let len = types.len(); | ||
| let post = if types.len() > 9 { |
Member
There was a problem hiding this comment.
might as well
Suggested change
| let post = if types.len() > 9 { | |
| let post = if len > 9 { |
Member
|
Great job at idempotency GH 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just found this while looking at other things