Adjust getMCSubtargetInfo signature for LLVM 23+#156156
Open
DKLoehr wants to merge 1 commit intorust-lang:mainfrom
Open
Adjust getMCSubtargetInfo signature for LLVM 23+#156156DKLoehr wants to merge 1 commit intorust-lang:mainfrom
DKLoehr wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @cuviper rustbot has assigned @cuviper. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
cuviper
reviewed
May 4, 2026
Comment on lines
+94
to
+100
| #if LLVM_VERSION_GE(23, 0) | ||
| const MCSubtargetInfo &MCInfo = Target->getMCSubtargetInfo(); | ||
| return MCInfo.checkFeatures(std::string("+") + Feature); | ||
| #else | ||
| const MCSubtargetInfo *MCInfo = Target->getMCSubtargetInfo(); | ||
| return MCInfo->checkFeatures(std::string("+") + Feature); | ||
| #endif |
Member
There was a problem hiding this comment.
Maybe it would be better to have the old code form a reference too? e.g.
Suggested change
| #if LLVM_VERSION_GE(23, 0) | |
| const MCSubtargetInfo &MCInfo = Target->getMCSubtargetInfo(); | |
| return MCInfo.checkFeatures(std::string("+") + Feature); | |
| #else | |
| const MCSubtargetInfo *MCInfo = Target->getMCSubtargetInfo(); | |
| return MCInfo->checkFeatures(std::string("+") + Feature); | |
| #endif | |
| #if LLVM_VERSION_GE(23, 0) | |
| const MCSubtargetInfo &MCInfo = Target->getMCSubtargetInfo(); | |
| #else | |
| const MCSubtargetInfo &MCInfo = *Target->getMCSubtargetInfo(); | |
| #endif | |
| return MCInfo.checkFeatures(std::string("+") + Feature); |
This way we don't duplicate the "interesting" code in each case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recent LLVM PR changed the signature of
getMCSubtargetInfoto return a reference instead of a pointer. This adjusts uses of the function incompiler/rustc_llvm/llvm-wrapper/PassWrapper.cppto account for the different signature.