diagnostics: point to coroutine body on higher-ranked auto trait errors#156226
Open
shivendra02467 wants to merge 1 commit intorust-lang:mainfrom
Open
diagnostics: point to coroutine body on higher-ranked auto trait errors#156226shivendra02467 wants to merge 1 commit intorust-lang:mainfrom
shivendra02467 wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #155880
When encountering a higher-ranked auto trait bound error involving a coroutine or async function,the trait solver previously used the span of the outermost cause (eg.
spawn(...)oris_send(...)).This PR modifies the
TraitPlaceholderMismatchformatting logic to walk down theObligationCauseCodechain.If the obligation originates from aty::Coroutineorty::CoroutineWitness, it extracts that specific span, providing a much more accurate underline for the user.Before:
After: