tests: check wasm compiler_builtins object architecture#156230
Open
Vastargazing wants to merge 1 commit intorust-lang:mainfrom
Open
tests: check wasm compiler_builtins object architecture#156230Vastargazing wants to merge 1 commit intorust-lang:mainfrom
Vastargazing wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
A-run-make
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
Add a run-make test that checks the `.o` members in the prebuilt `libcompiler_builtins` archive for `wasm32-wasip1` are wasm objects. This guards against building wasm compiler-rt fallbacks with the host C toolchain.
Vastargazing
force-pushed
the
tests/wasm-compiler-builtins-object-arch
branch
from
211904e to
b25f8a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #132802
This adds a run-make test for the wasm sysroot regression fixed in #137457
The test checks that the
.omembers in the prebuiltlibcompiler_builtinsrlib forwasm32-wasip1are wasm objects rather thanhost ELF objects. Before that fix, bootstrap could use the host C compiler for
compiler-rt fallbacks on wasm targets and end up embedding host objects into
the wasm sysroot.
I used
wasm32-wasip1because that's the wasm target covered by the existingtests/run-makeCI setup, and the test asserts that it actually saw.omembers in the archive.
r? @tgross35