fix: Guard SizeSkeleton::compute against stack overflow#156235
Open
rajgandhi1 wants to merge 3 commits intorust-lang:mainfrom
Open
fix: Guard SizeSkeleton::compute against stack overflow#156235rajgandhi1 wants to merge 3 commits intorust-lang:mainfrom
rajgandhi1 wants to merge 3 commits intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @adwinwhite rustbot has assigned @adwinwhite. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
May 6, 2026
| // Bail out if we've recursed too deeply (issue #156137); a cyclic type | ||
| // alias can otherwise blow the stack here. | ||
| if !tcx.recursion_limit().value_within_limit(depth) { | ||
| return Err(tcx.arena.alloc(LayoutError::Unknown(ty))); |
Contributor
There was a problem hiding this comment.
We should just raise a recursion limit error here. There's a function for doing that, several other recursion limit checks should be doing that, too.
Author
There was a problem hiding this comment.
you mean the emit_err(RecursionLimitReached{...}) pattern used in struct_tail_raw?
but SizeSkeleton::compute has no span. should I add it and create RecursionLimitReachedSizeSkeleton diagnostic in error.rs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156137
Fix: extract the recursion into a private
compute_innerthat carries a depth counter. When depth exceeds the crate's recursion limit, returnLayoutError::Unknownand let the existing transmute size-check produce a normal error instead of crashing.A regression test is included in
tests/ui/transmute/.