Suggest importable type that differs slightly#156239
Draft
GTimothy wants to merge 3 commits intorust-lang:mainfrom
Draft
Suggest importable type that differs slightly#156239GTimothy wants to merge 3 commits intorust-lang:mainfrom
GTimothy wants to merge 3 commits intorust-lang:mainfrom
Conversation
Co-authored-by: Chris Simpkins <git.simpkins@gmail.com>
adds a is_exact_match field to ImportSuggestion that is unused for now. suggestions now include 1-edit variations as suggestions
36cee45 to
a23f444
Compare
Contributor
Author
|
I see from the 247 failed tests that 1-edit difference is too big for small names. 'net' should probably NOT be suggested to replace 'new'... |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes to add types that differ slightly to suggested imports.
Previous discussion of this topic here: #72641 and in this PR: #72988
If that is still of interest, a discussion may be needed to limit or expand the included list.
I followed the suggestions in #72988.
In this initial change, the list is simply expanded to types with one char edit distance.
The tests are based on the tests by @chrissimpkins in #72988.
I added a
is_exact_matchfield toImportSuggestionto eventually modify the suggestion text accordingly, but for now it is ignored.for a more complex case:
SystemTame's edit-distance is 2, so not suggested.