Disambiguate identical type names in impl headers#156279
Open
qaijuang wants to merge 1 commit intorust-lang:mainfrom
Open
Disambiguate identical type names in impl headers#156279qaijuang wants to merge 1 commit intorust-lang:mainfrom
qaijuang wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
qaijuang
force-pushed
the
rustdoc-impl-disambiguation
branch
2 times, most recently
from
42c172b to
0fc7dd5
Compare
This comment has been minimized.
This comment has been minimized.
qaijuang
force-pushed
the
rustdoc-impl-disambiguation
branch
from
0fc7dd5 to
0cb49b0
Compare
rustbot
added
the
S-waiting-on-review
rustbot
removed
the
S-waiting-on-author
Collaborator
|
rustbot has assigned @GuillaumeGomez. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render impl header paths with enough qualification when the same visible path segment refers to different
DefIds in that header.Fixes #154960.