Skip to content

kernel_copy tests: properly join background threads#156375

Open
RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung:kernel_copy-background-threads
Open

kernel_copy tests: properly join background threads#156375
RalfJung wants to merge 1 commit intorust-lang:mainfrom
RalfJung:kernel_copy-background-threads

Conversation

@RalfJung
Copy link
Copy Markdown
Member

@RalfJung RalfJung commented May 9, 2026

This helps Miri because when there are threads just hanging in the background, we cannot check for memory leaks.

I think even without Miri this currently leads to 100% CPU load on one core for each of these threads: once the test function returns and sink gets dropped, the read in the thread will always immediately return 0, and then we just loop with that forever until the process exits.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 9, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 9, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, nia-e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants