Skip to content

suggest removing return type on use of void#156381

Open
euclio wants to merge 1 commit intorust-lang:mainfrom
euclio:void-suggest
Open

suggest removing return type on use of void#156381
euclio wants to merge 1 commit intorust-lang:mainfrom
euclio:void-suggest

Conversation

@euclio
Copy link
Copy Markdown
Contributor

@euclio euclio commented May 10, 2026

Fixes #100972 (comment).

This PR suggests removing the return type entirely if the user writes -> void, expecting it to work like C or TypeScript.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 10, 2026

r? @ShoyuVanilla

rustbot has assigned @ShoyuVanilla.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 18 candidates

@rust-log-analyzer

This comment has been minimized.

@Kivooeo
Copy link
Copy Markdown
Member

Kivooeo commented May 10, 2026

just wondering how often is possible to see this?

tbh i think is hard to know what user is meant by -> void, maybe user wanted to return c_void raw pointer, or they do have or had a void variable somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trying to return c_void should suggest to return () instead

5 participants