Add disabled-in-tests configuration to Clippy#156396
Open
smoelius wants to merge 2 commits into
Open
Conversation
Collaborator
|
The Clippy subtree was changed cc @rust-lang/clippy |
rustbot
added
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of rust-lang/rust-clippy#15600. It adds an option to Clippy's configuration file so that arbitrary lints can be disabled when
--testis passed torustc.Changes to the Rust compiler are needed to support the option. As @y21 noted in rust-lang/rust-clippy#15600 (comment), it would be surprising to disable a lint in tests and then see an unfulfilled lint expectation in non-test code. The approach taken by this PR is to filter out such diagnostics after Rust's
expect-related code has run.This PR is currently two commits:
expectfilter, described above.disabled-in-testsconfiguration to disable arbitrary lints in tests rust-clippy#15600).When tested locally, the following commands pass:
./x.py test./x.py test src/tools/clippy/testsr? @flip1995