resolve instances in ctfe based on current const context#156454
Open
fee1-dead wants to merge 2 commits into
Open
resolve instances in ctfe based on current const context#156454fee1-dead wants to merge 2 commits into
fee1-dead wants to merge 2 commits into
Conversation
Collaborator
rustbot
added
S-waiting-on-review
Collaborator
|
r? @mu001999 rustbot has assigned @mu001999. Use Why was this reviewer chosen?The reviewer was selected based on:
|
rustbot
added
S-waiting-on-author
fee1-dead
force-pushed
the
const-min-spec-not-nonconst
branch
from
f8e940c to
7ffb868
Compare
RalfJung
reviewed
May 11, 2026
This comment has been minimized.
This comment has been minimized.
fee1-dead
force-pushed
the
const-min-spec-not-nonconst
branch
from
99ddb40 to
fc87f6c
Compare
rustbot
added
S-waiting-on-review
oli-obk
reviewed
May 13, 2026
Comment on lines
+117
to
+118
| let candidate = if constness == Constness::Const && tcx.next_trait_solver_globally() { | ||
| tcx.codegen_select_candidate_for_ctfe(input) |
Contributor
There was a problem hiding this comment.
How riddiculous would it be to just always use the next trait solver for this? Does mixing the trait solvers like that get us into any trouble that is more problematic than min_spec unsoundness?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to figure out what to do with the duplicated code from
codegen_select_candidate.Fixes #148200.