Skip to content

mark the 'import linkage' statics as unnamed_addr#156467

Open
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:weak-import-addr
Open

mark the 'import linkage' statics as unnamed_addr#156467
RalfJung wants to merge 1 commit into
rust-lang:mainfrom
RalfJung:weak-import-addr

Conversation

@RalfJung
Copy link
Copy Markdown
Member

@RalfJung RalfJung commented May 11, 2026

No description provided.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 11, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 11, 2026

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 16 candidates

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented May 11, 2026

r? @bjorn3
(or @nikic )

@rustbot rustbot assigned bjorn3 and unassigned mejrs May 11, 2026
@bjorn3
Copy link
Copy Markdown
Member

bjorn3 commented May 11, 2026

r=me if CI passes

@RalfJung RalfJung force-pushed the weak-import-addr branch from b19e02a to a36a97f Compare May 11, 2026 19:19
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 11, 2026

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

@rustbot rustbot added the PG-exploit-mitigations Project group: Exploit mitigations label May 11, 2026
This was referenced May 11, 2026
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@bjorn3 bjorn3

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RalfJung @rustbot @bjorn3 @mejrs