remove/update various cfg(miri)#156492
Open
RalfJung wants to merge 1 commit into
Open
Conversation
rustbot
added
O-unix
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Member
Author
|
@bors try jobs=*gnu-aux |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
May 12, 2026
remove/update various cfg(miri) try-job: *gnu-aux
RalfJung
commented
May 12, 2026
| /// https://pubs.opengroup.org/onlinepubs/9699919799/functions/confstr.html | ||
| // | ||
| // FIXME: Support `confstr` in Miri. | ||
| #[cfg(all(target_vendor = "apple", not(miri)))] |
Member
Author
There was a problem hiding this comment.
I think we don't actually ever hit this code path in what we currently test... and if we do, I'll add a little stub shim in Miri. That's almost always better than cfg.
This comment has been minimized.
This comment has been minimized.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went over all
cfg(miri)inlibrary/. Most of the things I noticed have become separate PRs; these here are the few remaining scattered little fixes in various places.