Avoid synthetic auto-trait ICE with next solver in rustdoc#156523
Avoid synthetic auto-trait ICE with next solver in rustdoc#156523TaKO8Ki wants to merge 1 commit into
Conversation
|
r? @camelid rustbot has assigned @camelid. Use Why was this reviewer chosen?The reviewer was selected based on:
|
There was a problem hiding this comment.
Could you explain a bit more about the purpose of this PR? It seems like it just turns a rustdoc ICE into silently producing incorrect results with -Znext-solver, which doesn't seem good to me. Is it to test the other parts of rustdoc with -Znext-solver? Apologies if I'm missing some context.
|
Sorry, I opened this PR while I was still debugging and before I had completed the changes. I think it is better for rustdoc to return a normal error with
rather than causing an ICE. What do you think? |
3e6dd0e to
0580113
Compare
Fixes #156487
AutoTraitFinderstill uses old-solver-only selection APIs. When rustdoc runs with-Znext-solver=globally, synthetic auto-trait impl generation reaches that path with the new solver enabled and ICEs in trait selection.