Skip to content

Add ChildExt::kill_process_group#156539

Open
jmillikin wants to merge 2 commits into
rust-lang:mainfrom
jmillikin:unix-childext-killpg
Open

Add ChildExt::kill_process_group#156539
jmillikin wants to merge 2 commits into
rust-lang:mainfrom
jmillikin:unix-childext-killpg

Conversation

@jmillikin
Copy link
Copy Markdown
Contributor

@jmillikin jmillikin commented May 13, 2026

ACP: rust-lang/libs-team#791
Tracking issue: #156537

@jmillikin
Add send_process_group_signal to existing unix_send_signal feature
2c30279 
This function wraps POSIX `killpg()`, and on Linux additionally
may be implemented by `pidfd_send_signal`.
@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 13, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 13, 2026

r? @nia-e

rustbot has assigned @nia-e.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ChrisDenton, libs
  • @ChrisDenton, libs expanded to 8 candidates
  • Random selection from Mark-Simulacrum, nia-e

nia-e
nia-e requested changes May 13, 2026
View reviewed changes
Comment thread library/std/src/os/unix/process.rs
Comment thread library/std/src/os/unix/process.rs Outdated
Comment thread library/std/src/os/unix/process.rs
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 13, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@jmillikin
Add ChildExt::kill_process_group
7bf5fe7 
This function wraps POSIX `killpg(pid, SIGKILL)`, and on Linux
additionally may be implemented by `pidfd_send_signal`.
@jmillikin jmillikin force-pushed the unix-childext-killpg branch from 3d3f33e to 7bf5fe7 Compare May 13, 2026 13:40
@jmillikin
Copy link
Copy Markdown
Contributor Author

jmillikin commented May 13, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2026
@nia-e
Copy link
Copy Markdown
Member

nia-e commented May 13, 2026

@bors r+ rollup

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented May 13, 2026

📌 Commit 7bf5fe7 has been approved by nia-e

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nia-e nia-e nia-e requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@nia-e nia-e

Labels

O-unix Operating system: Unix-like S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmillikin @rustbot @nia-e