Skip to content

Fix Xtensa vaarg stack transition algorithm#156568

Open
SergioGasquez wants to merge 1 commit into
rust-lang:mainfrom
SergioGasquez:fix/xtensa-vaarg-alg
Open

Fix Xtensa vaarg stack transition algorithm#156568
SergioGasquez wants to merge 1 commit into
rust-lang:mainfrom
SergioGasquez:fix/xtensa-vaarg-alg

Conversation

@SergioGasquez
Copy link
Copy Markdown
Contributor

@SergioGasquez SergioGasquez commented May 14, 2026

Fixes Xtensa va arg stack transition algorithm

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 17 candidates

folkertdev
folkertdev reviewed May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? me

Could you add an assembly test similar to https://github.com/rust-lang/rust/blob/main/tests/assembly-llvm/c-variadic/sparc.rs?

Also what triggered or caught this issue?

@folkertdev folkertdev added the F-c_variadic `#![feature(c_variadic)]` label May 14, 2026
folkertdev

This comment was marked as outdated.

Sign in to view

folkertdev
folkertdev requested changes May 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@folkertdev folkertdev left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? folkertdev

Could you add an assembly test similar to https://github.com/rust-lang/rust/blob/main/tests/assembly-llvm/c-variadic/sparc.rs?

Also what triggered or caught this issue?

View changes since this review

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 14, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 14, 2026

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdev folkertdev folkertdev requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@folkertdev folkertdev

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. F-c_variadic `#![feature(c_variadic)]` S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SergioGasquez @rustbot @folkertdev @nnethercote