Don't drop uninit memory when MapWindows::clone panics#156588
Open
Jules-Bertholet wants to merge 1 commit into
Open
Don't drop uninit memory when MapWindows::clone panics#156588Jules-Bertholet wants to merge 1 commit into
MapWindows::clone panics#156588Jules-Bertholet wants to merge 1 commit into
Conversation
Collaborator
|
The Miri subtree was changed cc @rust-lang/miri |
rustbot
added
S-waiting-on-review
Collaborator
|
r? @scottmcm rustbot has assigned @scottmcm. Use Why was this reviewer chosen?The reviewer was selected based on:
|
RalfJung
reviewed
May 15, 2026
Member
There was a problem hiding this comment.
We typically add tests for std regressions in the std (or better, core/alloc) test suite. There are already some Miri-targeted tests there.
RalfJung
reviewed
May 15, 2026
Comment on lines
+33
to
+34
| /// `Buffer` uses two times of space to reduce moves among the iterations. | ||
| /// `Buffer<T, N>` is semantically `[MaybeUninit<T>; 2 * N]`. However, due |
Member
There was a problem hiding this comment.
The second sentence mostly repeats the first one, doesn't it? (and also the first one isn't quite grammatical)
Suggested change
| /// `Buffer` uses two times of space to reduce moves among the iterations. | |
| /// `Buffer<T, N>` is semantically `[MaybeUninit<T>; 2 * N]`. However, due | |
| /// `Buffer<T, N>` is semantically `[MaybeUninit<T>; 2 * N]`. This helps | |
| /// reduce moves while iterating. However, due |
RalfJung
reviewed
May 15, 2026
Comment on lines
+43
to
+44
| // | ||
| // FIXME make these unsafe fields once that feature is ready |
Member
There was a problem hiding this comment.
Suggested change
| // | |
| // FIXME make these unsafe fields once that feature is ready |
I don't think it's worth adding this FIXME to very single type with an invariant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #156501, using the approach suggested in @bjorn3's comment #156517 (comment)