Skip to content

Use print instead of po in debuginfo path test#156769

Open
fallofpheonix wants to merge 1 commit into
rust-lang:mainfrom
fallofpheonix:fix-path-lldb-macos
Open

Use print instead of po in debuginfo path test#156769
fallofpheonix wants to merge 1 commit into
rust-lang:mainfrom
fallofpheonix:fix-path-lldb-macos

Conversation

@fallofpheonix
Copy link
Copy Markdown

@fallofpheonix fallofpheonix commented May 20, 2026

Fixes #156660

This fixes tests/debuginfo/path.rs failing on newer Apple LLDB versions.

Root cause:
Apple LLDB 2100 reports missing Rust language plugin support:

warning: po was unsuccessful, running p instead

As a result, po falls back to p, producing expanded output that no longer matches the existing lldb-check directives.

Changes:

  • replace po with print
  • relax lldb-check expectations using [...]
  • preserve validation of the displayed path value

This also aligns path.rs with the rest of the debuginfo tests, as it appears to be the only test using po.

Copilot AI review requested due to automatic review settings May 20, 2026 08:55
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 20, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 20, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 73 candidates
  • Random selection from 20 candidates

@fallofpheonix
Copy link
Copy Markdown
Author

Reproduced on Apple LLDB 2100.

po falls back to p because LLDB reports missing Rust language plugin support. path.rs appears to be the only debuginfo test using po.

Submitted a PR replacing po with print and relaxing the checks.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates a Rust debuginfo LLDB test to be compatible with newer Apple LLDB versions where po can fail/fallback and change output formatting, causing lldb-check mismatches.

Changes:

  • Remove lldb-command:po usage from tests/debuginfo/path.rs.
  • Relax lldb-check patterns to tolerate expanded/variant LLDB output while still matching the "/some/path" value.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests/debuginfo/path.rs test failing on MacOS

4 participants