Avoid cloning CFG-related analysis data.

[dianqk]

For perf.

[rust-log-analyzer]

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[RUSTC-TIMING] rustc_ast_passes test:false 0.953
error: using `.clone()` on a ref-counted pointer
  --> compiler/rustc_middle/src/mir/basic_blocks.rs:72:9
   |
72 |         self.cache.clone()
   |         ^^^^^^^^^^^^^^^^^^ help: try: `std::sync::Arc::<mir::basic_blocks::CfgCache>::clone(&self.cache)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_ref_ptr
   = note: requested on the command line with `-D clippy::clone-on-ref-ptr`

[RUSTC-TIMING] rustc_middle test:false 22.388

[dianqk]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 218c186 (218c18693cbb9ae14f53b685355647f5dbeb1e44, parent: b52edc25bfbaa955b4b83c10f998e5224c3478b2)

[rust-timer]

Finished benchmarking commit (218c186): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking means the PR may be perf-sensitive. It's automatically marked not fit for rolling up. Overriding is possible but disadvised: it risks changing compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.7%	[-0.7%, -0.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.7%	[-0.7%, -0.7%]	1

Max RSS (memory usage)

Results (primary -0.1%, secondary -2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	7.9%	[7.9%, 7.9%]	1
Regressions ❌ (secondary)	2.6%	[2.6%, 2.6%]	1
Improvements ✅ (primary)	-2.8%	[-3.6%, -2.3%]	3
Improvements ✅ (secondary)	-4.4%	[-7.1%, -1.7%]	2
All ❌✅ (primary)	-0.1%	[-3.6%, 7.9%]	4

Cycles

Results (primary 2.2%, secondary -4.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.2%	[2.2%, 2.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.2%	[-4.3%, -4.0%]	3
All ❌✅ (primary)	2.2%	[2.2%, 2.2%]	1

Binary size

Results (primary 0.1%, secondary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.1%]	51
Regressions ❌ (secondary)	0.1%	[0.0%, 0.1%]	25
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[0.0%, 0.1%]	51

Bootstrap: 513.181s -> 524.394s (2.18%)
Artifact size: 400.52 MiB -> 400.58 MiB (0.02%)