Prevent infinite recursion and OOM in project_and_unify_term#156842
Open
BloodStainedCrow wants to merge 1 commit into
Open
Prevent infinite recursion and OOM in project_and_unify_term#156842BloodStainedCrow wants to merge 1 commit into
project_and_unify_term#156842BloodStainedCrow wants to merge 1 commit into
Conversation
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
project_and_unify_term
Author
|
I have added the recursion check to the "lowest" function which added the new obligation, So it might make sense to move this check further up to cover more of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents an infinite recursion when using the old trait solver.
Fixes #156615.
Note that the example in #156615 encounters this infinite recursion in
report_ambiguity_errors.The overflow abort introduced here shadows the original error for which we are generating a report, which is unfortunate but preferable to hangs/OOMs:
Ideally, we could report the original error AND report the overflow while generating the report, something like this: