allow repeated repr attributes#156856
Open
ettolrach wants to merge 1 commit into
Open
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
Collaborator
|
r? @mejrs rustbot has assigned @mejrs. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
Thanks for the contribution! Would you mind adding tests? You can use the relevant repro examples from the issue as the basis for the tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In principle, fixes #156029. That issue does mention the "inconsistency" of multiple "C" reprs mixed with a single integer repr being accepted, while multiple "Rust" reprs mixed with a single integer repr aren't. I do believe this is intentional, since the Rust repr cannot be mixed with integer reprs.
Also, I'm not sure whether the current behaviour regarding multiple align reprs should be changed. While it's inconsistent that multiple, mixed aligns are accepted (and the largest is used), multiple packed repr aren't allowed. I don't want to change this since it's making the compiler less permissive, not more, like the rest of my changes.