Add missing PartialEq impls for Vec and array#156897
Conversation
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
a789ba6 to
a580e25
Compare
This comment has been minimized.
This comment has been minimized.
a580e25 to
921a74c
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
This PR adds the missing `PartialEq` implementations between `Vec<T>` and `[U; N]`, including symmetric and reference variants.
921a74c to
9361fa7
Compare
|
This seems like it could cause inference failures. Maybe needs a crater run? |
|
@fallofpheonix please do not trigger unprompted reviews from bots in our repository, thanks. This was already pointed out in #156876 (comment) |
|
A pull request is already in flight for #149045 and this one will just lead to duplicating process because it overlaps. Though why didn't a crater get run for that one...? |
|
Closing in favor of the existing PR #149045 as pointed out by @workingjubilee. Thanks for the heads up, and apologies for the duplicate! Also, noted on the unprompted bot reviews (@apiraino) — I'll make sure not to trigger them in the future. |
Fixes #149017.
This PR adds the missing
PartialEqimplementations betweenVec<T>and[U; N], specifically:[T; N] == Vec<U>&[T; N] == Vec<U>&mut [T; N] == Vec<U>Vec<T> == &mut [U; N]Tested locally by adding equality assertions in
library/alloctests/tests/vec.rs.Please let me know if any other adjustments are needed.