Rollup of 2 pull requests#156910
Closed
JonathanBrouwer wants to merge 35 commits into
Closed
Conversation
This allows for simplification of the intrinsic-test generator as it no longer needs to maintain readable formatting.
This isn't necessary when rustfmt is being used to make sure the generated sources are formatted.
intrinsic-test: run rustfmt on generated sources
Improve documentation for Arm intrinsic filtering - why we test some intrinsics and not others.
This flag was missing documentation but the other flags had documentation
It isn't necessarily obvious what this function does
intrinsic-test: add lots of documentation
`ArmIntrinsicType` does not need a `target` field and `parse_intrinsic_type` can be a free function that returns an `IntrinsicType` which can be wrapped in an `ArmIntrinsicType` by the caller.
Updates `parse_intrinsic_type` to support SVE intrinsic types, with the limited changes required to `IntrinsicType` and relevant users of the `simd_len` to preserve existing behaviour, assuming the tool never attempts to generate tests for SVE intrinsics (which it doesn't yet)
…ypes intrinsic-test: sve type parsing and constraints
This module only defined a single function that could easily just be inlined into its only caller.
loongarch: Use `intrinsics::simd` for vilv{h,l}
stdarch-gen-hexagon-scalar: Do not emit inline(always) if target_feature is used
…-size intrinsic-test fixes for low intrinsic, high core counts
Add GCC run to intrinsic-test
GCC and LLVM both only allow using the CRC intrinsics on LA64.
Clang and GCC use char and short for the data parameter type where appropriate. The LLVM intrinsics take an i32. We should match clang and perform a cast here.
…e-arm-argument intrinsic-test: remove `arm::argument` module
Several fixes to the loongarch CRC intrinsics
The `needs-asm-mnemonic` directive was very general, but in practice was only being used for `ret`. There are very few other mnemonics that it could plausibly be useful for (e.g. `nop`), because any instruction that requires arguments is probably going to be non-portable. This PR replaces `needs-asm-mnemonic` with a simpler `needs-asm-ret` directive that uses the same machinery as other simple needs directives. If we happend to need more mnemonics in the future, we can just add more simple directives as appropriate (e.g. `needs-asm-nop`).
…, r=folkertdev stdarch subtree update Subtree update of `stdarch` to rust-lang/stdarch@5e930b6. Created using https://github.com/rust-lang/josh-sync. r? @ghost
compiletest: Simplify `//@ needs-asm-mnemonic: ret` to just `//@ needs-asm-ret` - Simplification of rust-lang#155692. --- The `needs-asm-mnemonic` directive was very general, but in practice was only being used for `ret`. There are very few other mnemonics that it could plausibly be useful for (e.g. `nop`), because any instruction that requires arguments is probably going to be non-portable. This PR replaces `needs-asm-mnemonic` with a simpler `needs-asm-ret` directive that uses the same machinery as other simple needs directives. If we happend to need more mnemonics in the future, we can just add more simple directives as appropriate (e.g. `needs-asm-nop`).
rustbot
added
A-compiletest
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
//@ needs-asm-mnemonic: retto just//@ needs-asm-ret#156901 (compiletest: Simplify//@ needs-asm-mnemonic: retto just//@ needs-asm-ret)r? @ghost
Create a similar rollup