add help when constructing ADTs with private fields#156943
Open
euclio wants to merge 1 commit into
Open
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
SpriteOvO
requested changes
May 26, 2026
Comment on lines
+2644
to
+2646
| format!( | ||
| "initializer expressions cannot construct structs with private fields" | ||
| ), |
Member
There was a problem hiding this comment.
Maybe
Suggested change
| format!( | |
| "initializer expressions cannot construct structs with private fields" | |
| ), | |
| format!( | |
| "initializer syntax cannot be used to construct structs with inaccessible private fields" | |
| ), |
?
| --> $DIR/suggest-private-fields.rs:17:9 | ||
| | | ||
| LL | bb: 20, | ||
| | ^^ `B` does not have this field |
Member
There was a problem hiding this comment.
Perhaps keeping this message is better? "Struct does not have this field" and "Struct have inaccessible private fields" convey two different pieces of information.
Comment on lines
1
to
5
| error[E0451]: field `b` of struct `Foo` is private | ||
| --> $DIR/E0451.rs:14:21 | ||
| | | ||
| LL | let bar::Foo{a, b} = foo; | ||
| | ^ private field |
Member
There was a problem hiding this comment.
This should also trigger a help message.
Comment on lines
7
to
+17
| error[E0451]: field `b` of struct `Foo` is private | ||
| --> $DIR/E0451.rs:18:29 | ||
| | | ||
| LL | let f = bar::Foo{ a: 0, b: 0 }; | ||
| | ^ private field | ||
| | | ||
| help: initializer expressions cannot construct structs with private fields | ||
| --> $DIR/E0451.rs:18:13 | ||
| | | ||
| LL | let f = bar::Foo{ a: 0, b: 0 }; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^ |
Member
There was a problem hiding this comment.
Personally, I feel the new help message creates extra noise in some cases. For example here. I’d rather expect this to become a note, because help is used to provide suggestions.
error[E0451]: field `b` of struct `Foo` is private
--> $DIR/E0451.rs:18:29
|
LL | let f = bar::Foo{ a: 0, b: 0 };
| ^ private field
|
+ note: initializer expressions cannot construct structs with private fields
- help: initializer expressions cannot construct structs with private fields
- --> $DIR/E0451.rs:18:13
- |
- LL | let f = bar::Foo{ a: 0, b: 0 };
- | ^^^^^^^^^^^^^^^^^^^^^^
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153259.
I'm a little unsure about the wording. I don't want to imply that private fields can never be used in initializer expressions, since private fields are fine if the fields are in the same module. The existing error message uses the term "private", though, so I went for consistency.
I also wonder if it would be useful to include a note about
fn newbeing a common idiom to construct private structs, or even suggesting it if it exists.