Skip to content

[beta] Revert "Build shared LLVM lib for windows-gnullvm"#156962

Open
mati865 wants to merge 1 commit into
rust-lang:betafrom
mati865:revert-gnullvm-link-shared-beta
Open

[beta] Revert "Build shared LLVM lib for windows-gnullvm"#156962
mati865 wants to merge 1 commit into
rust-lang:betafrom
mati865:revert-gnullvm-link-shared-beta

Conversation

@mati865
Copy link
Copy Markdown
Member

@mati865 mati865 commented May 26, 2026

This reverts commit 1d1280a.

Reapply #155285 to the new beta because #156229 missed the train by a couple of hours.

This reverts commit 1d1280a.

Looks like this causes problems with certain LLVM bin tools not finding
`libLLVM` on `*-windows-gnullvm`. This commit is a _minimal_ revert to
return us to known state to alleviate time pressure to investigate.
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 26, 2026

Warning

If you are changing how CI LLVM is built or linked, make sure to bump
src/bootstrap/download-ci-llvm-stamp.

cc @jieyouxu

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels May 26, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 26, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, marcoieni

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 26, 2026

⚠️ Warning ⚠️

  • Pull requests are usually filed against the main branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  PR_CI_JOB: 1
  SKIP_SUBMODULES: src/gcc
  IMAGE: tidy
##[endgroup]
error: PRs changing the `nightly` channel should be sent to the `main` branch!
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"
echo "disk usage:"
df -h
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

@mati865 mati865 changed the title Revert "Build shared LLVM lib for windows-gnullvm" [beta] Revert "Build shared LLVM lib for windows-gnullvm" May 26, 2026
@mati865
Copy link
Copy Markdown
Member Author

mati865 commented May 26, 2026

I edited the title, but perhaps it got lost when I changed the target branch because it caused the page to reload (although the modified description remained modified).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants